Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change html_content to content_html #81

Merged
merged 1 commit into from Dec 16, 2018
Merged

Change html_content to content_html #81

merged 1 commit into from Dec 16, 2018

Conversation

leereamsnyder
Copy link
Contributor

The JSON feed specification https://jsonfeed.org/version/1 indicates that content should be either content_html or content_text

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.652% when pulling e9955b5 on leereamsnyder:jsonfeed-spec into eb08b96 on jpmonette:master.

aslafy-z
aslafy-z approved these changes Nov 14, 2018
View reviewed changes
Copy link

@aslafy-z aslafy-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjm
Copy link

mjm commented Dec 6, 2018

Hi! Could this be merged? I really like using this to generate my feeds, but right now the JSON feed is not compliant.

@jpmonette jpmonette merged commit c4666db into jpmonette:master Dec 16, 2018
@jpmonette
Copy link
Owner

This has been merged + part of 2.0.2.

Thanks!

@leereamsnyder leereamsnyder deleted the jsonfeed-spec branch December 17, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslafy-z aslafy-z aslafy-z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@leereamsnyder @coveralls @mjm @jpmonette @aslafy-z