You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, a very nice parameterization is used to test that QAOA objective for LABS is computed the same way for all simulators (see tests/test_objectives.py).
However, for MaxCut there are two separate files that manually test only a small number of simulators (I believe, only "auto" and "qiskit"): tests/test_qaoa_objective_maxcut.py and tests/test_maxcut.py.
At the same time, parameterization for LABS is missing "qiskit" simulator. I suspect this lack of test coverage is what caused #28.
The request is to add parameterization to MaxCut tests along the lines of how LABS tests are parameterized in tests/test_objectives.py and to add "qiskit" simulator to the tests for LABS objective.
I would also suggest the following minor refactoring:
Currently, a very nice parameterization is used to test that QAOA objective for LABS is computed the same way for all simulators (see
tests/test_objectives.py
).However, for MaxCut there are two separate files that manually test only a small number of simulators (I believe, only "auto" and "qiskit"):
tests/test_qaoa_objective_maxcut.py
andtests/test_maxcut.py
.At the same time, parameterization for LABS is missing "qiskit" simulator. I suspect this lack of test coverage is what caused #28.
The request is to add parameterization to MaxCut tests along the lines of how LABS tests are parameterized in
tests/test_objectives.py
and to add "qiskit" simulator to the tests for LABS objective.I would also suggest the following minor refactoring:
tests/test_objectives.py
->tests/test_qaoa_objective_labs.py
test_maxcut_obj
fromtests/test_maxcut.py
totests/test_qaoa_objective_maxcut.py
The text was updated successfully, but these errors were encountered: