Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameterization of LABS tests and parameterize MaxCut tests #29

Closed
rsln-s opened this issue Dec 19, 2023 · 0 comments · Fixed by #31
Closed

Fix parameterization of LABS tests and parameterize MaxCut tests #29

rsln-s opened this issue Dec 19, 2023 · 0 comments · Fixed by #31
Assignees

Comments

@rsln-s
Copy link
Contributor

rsln-s commented Dec 19, 2023

Currently, a very nice parameterization is used to test that QAOA objective for LABS is computed the same way for all simulators (see tests/test_objectives.py).

However, for MaxCut there are two separate files that manually test only a small number of simulators (I believe, only "auto" and "qiskit"): tests/test_qaoa_objective_maxcut.py and tests/test_maxcut.py.

At the same time, parameterization for LABS is missing "qiskit" simulator. I suspect this lack of test coverage is what caused #28.

The request is to add parameterization to MaxCut tests along the lines of how LABS tests are parameterized in tests/test_objectives.py and to add "qiskit" simulator to the tests for LABS objective.

I would also suggest the following minor refactoring:

  • tests/test_objectives.py -> tests/test_qaoa_objective_labs.py
  • Move all functions except test_maxcut_obj from tests/test_maxcut.py to tests/test_qaoa_objective_maxcut.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants