try out potential fix for missing "everyone" ACE in fs.smbfs

jpmorganchase · Apr 14, 2020 · f3079d5 · f3079d5
1 parent 5e796e1
commit f3079d5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/appveyor.yml b/appveyor.yml
@@ -48,7 +48,7 @@ install:
 
 test_script:
 # uncomment to allow remote login to windows ci vm via rdp
-- ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))
+# - ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))
 
 # lint the python code
 # - python -m flake8 jupyterfs setup.py

diff --git a/jupyterfs/tests/test_pyfilesystem_manager.py b/jupyterfs/tests/test_pyfilesystem_manager.py
@@ -25,9 +25,9 @@
 test_hostname_smb_docker_share = 'TESTNET'
 test_name_port_smb_docker_share = 3669
 
-test_direct_tcp_smb_os_share = True
+test_direct_tcp_smb_os_share = False
 test_host_smb_os_share = socket.gethostbyname_ex(socket.gethostname())[2][-1]
-test_smb_port_smb_os_share = 445
+test_smb_port_smb_os_share = 139
 
 _test_file_model = {
     'content': test_content,

diff --git a/setup.py b/setup.py
@@ -36,7 +36,7 @@
     'boto3',
     'docker',
     'fs-miniofs',
-    'fs.smbfs @ git+https://github.com/telamonian/fs.smbfs.git@host-name-arg#egg=fs.smbfs',
+    'fs.smbfs @ git+https://github.com/telamonian/fs.smbfs.git@dont_assume_everyone_ace_exists#egg=fs.smbfs',
     'mock',
     'pysmb',
     'pytest',