Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #132

Merged
merged 5 commits into from
Apr 9, 2022
Merged

Fix CI #132

merged 5 commits into from
Apr 9, 2022

Conversation

reoono
Copy link
Contributor

@reoono reoono commented Apr 1, 2022

References

Fixes #121

Summary

Binder Badge

After checking the official Binder documentation, I found that the permissions were not set properly.
The format was referred to the ipywidget repository.
https://github.com/jupyter-widgets/ipywidgets/blob/88cec8be2869e75760a6a99bba129e6011d9043f/.github/workflows/binder-on-pr.yml#L7

Azure Pipeline

macOS-10.14 images were no longer available. Therefore, I modified it to use the latest image.
https://devblogs.microsoft.com/devops/hosted-pipelines-image-deprecation/

However, the new image was failing to install Docker, so I corrected the relevant step based on the following comment.
docker/for-mac#2359 (comment)

Appveyor

The installation of pywinpty was failing due to a newer version of Python. Therefore, the necessary dependencies were added to the installation.

Also, when the installation error was resolved, NotConnected error occurred in Test_FSManager_smb_os_share.
While verifying with RDP, in the following URI, the hostname was appveyor-vm.appveyor.local.

 uri = 'smb://{username}:{passwd}@{host}:{port}/{share}?hostname={hostname}&direct-tcp={direct_tcp}'

When I corrected hostname to appveyor , the connection was established.
So I modified to use gethostname() instead of getfqdn().

@reoono
Copy link
Contributor Author

reoono commented Apr 1, 2022

It seems that the Binder Badge fails this time because it is before the merge.

@timkpaine
Copy link
Collaborator

Thanks for looking into this! I'm probably going to move everything to GitHub actions, but I will reuse these commits when I do that.

@reoono
Copy link
Contributor Author

reoono commented Apr 1, 2022

Thank you for your prompt comments.
I am glad it was helpful.

@reoono
Copy link
Contributor Author

reoono commented Apr 1, 2022

By the way, does the problem @telamonian mentioned in the comment here go away with the move to GitHub Actions?

I would like to know if there are any policy or progress updates on the move to GitHub Action, as I have worked on this as I still think the current CI configuration is useful.

@timkpaine
Copy link
Collaborator

@telamonian I'm +1 on this for now pending your review, I'm going to work a bit on jupyterfs again but I don't have time to move to GitHub actions yet.

@timkpaine
Copy link
Collaborator

@reoono feel free to add yourself here https://github.com/jpmorganchase/jupyter-fs/blob/main/AUTHORS

@reoono
Copy link
Contributor Author

reoono commented Apr 5, 2022

Thank you for your kind words.
I have added my name to the AUTHOR and have also sent the CLA.
(Of course, my name can be removed if it is inappropriate.)

@timkpaine timkpaine merged commit 88abacd into jpmorganchase:main Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI
2 participants