Allow for release on pypi by applying diff from althonos/fs.smbfs#11 as a monkeypatch #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, here's the results from the windows ci on fdea8a4. It's passing, which shows that the monkeypatch in this PR is indeed fixing the same bug as the althonos/fs.smbfs#11 PR itself |
|
Woo! 20 minutes after I opened this PR althonos/fs.smbfs#11 finally got merged in. It's now part of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #32
Haven't head back from @althonos about althonos/fs.smbfs#11, so I'm going to go ahead and publish 0.0.2 using a workaround. Not the prettiest solution in the world, but probably the simplest. Pull in the real
fs.smbfsin setup.py and then applies the diff from my PR as a monkeypatch.Once this gets pulled in we'll be able to actually complete the release of 0.0.2 to pypi (I already did a release to test pypi and it went through perfectly).