Use non-zero exit codes to determine child process failures #1022
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ays have content relating to the debugger connecting. This PR therefore adds a check that the `exitCode` for the `yarnpkg` child process is non-zero when checking for a failed attempt to read yarn workspace details rather than simply the presence of content on `stderr`.
🦋 Changeset detectedLatest commit: b188951 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Nov 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running node through some IDE debugging tools,
stderrwill always have content relating to the debugger connecting.This PR therefore adds a check that the
exitCodefor theyarnpkgchild process is non-zero when checking for a failed attempt to read yarn workspace details rather than simply the presence of content onstderr.Closes #1021 1021