Copy LICENSE files when building packages #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bff7fe1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshwooding
force-pushed
the
copy-license-when-building
branch
3 times, most recently
from
30c57c1
to
d77f6b0
Compare
joshwooding
force-pushed
the
copy-license-when-building
branch
from
d77f6b0
to
63b79be
Compare
2 tasks
|
@joshwooding sorry for the delay, will take a look at this shortly in the next days |
benpryke
reviewed
Oct 21, 2022
packages/modular-scripts/src/build/buildPackage/maybeCopyRootLicense.ts
Outdated
Show resolved
Hide resolved
|
LGTM, I think this is ready to merge after addressing @benpryke's feedback. |
joshwooding
force-pushed
the
copy-license-when-building
branch
from
63b79be
to
178b4d1
Compare
benpryke
reviewed
Oct 25, 2022
packages/modular-scripts/src/build/buildPackage/maybeCopyRootLicense.ts
Outdated
Show resolved
Hide resolved
joshwooding
force-pushed
the
copy-license-when-building
branch
from
178b4d1
to
5c6ecd7
Compare
joshwooding
force-pushed
the
copy-license-when-building
branch
2 times, most recently
from
0e7c7b6
to
415a369
Compare
joshwooding
force-pushed
the
copy-license-when-building
branch
from
415a369
to
bff7fe1
Compare
|
Are there any more changes needed here? |
|
@cristiano-belloni Do you know if this PR can be merged too |
cristiano-belloni
approved these changes
Dec 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2160