Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repository field generation on Windows #2218

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fix repository field generation on Windows #2218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/large-icons-jump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'modular-scripts': patch
---

Fix repository field generation on Windows
5 changes: 4 additions & 1 deletion packages/modular-scripts/src/build/buildPackage/getRepositoryField.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ async function getRelativePathInRepo(packagePath: string) {
['rev-parse', '--show-toplevel'],
{ stdout: 'pipe' },
);
return path.relative(gitRepoPath, packagePath);
return path
.relative(gitRepoPath, packagePath)
.split(path.win32.sep)
Copy link
Contributor Author

@joshwooding joshwooding Dec 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as the utils in esbuild-scripts, so probably can be cleaned up in the future to use the same utility

.join(path.posix.sep);
}

export async function getRepositoryField(packagePath: string) {
Expand Down