Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw with non-modular packages and exclude them from selection #2268

Merged
merged 6 commits into from Jan 26, 2023
Merged

Do not throw with non-modular packages and exclude them from selection #2268

merged 6 commits into from Jan 26, 2023

Conversation

cristiano-belloni
Copy link
Contributor

@cristiano-belloni cristiano-belloni commented Jan 25, 2023 •
edited by benpryke

  • Make check pass in presence of non-modular packages
  • Show non-modular packages as unknown type in workspace
  • Do not try to test non-Modular packages
  • Fix wording in build
  • Show correct data in analyze

@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2023 •
edited

🦋 Changeset detected

Latest commit: cc32ad9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
modular-scripts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cristiano-belloni cristiano-belloni changed the title Fix check, workspace output and filter out non-modular packages from … Do not error on non-modular packages Jan 25, 2023
@cristiano-belloni cristiano-belloni changed the base branch from main to feature/v4.1 January 25, 2023 17:31
@cristiano-belloni cristiano-belloni changed the title Do not error on non-modular packages Do not throw with non-modular packages Jan 26, 2023
@cristiano-belloni cristiano-belloni marked this pull request as ready for review January 26, 2023 10:28
@cristiano-belloni cristiano-belloni changed the title Do not throw with non-modular packages Do not throw with non-modular packages and exclude them from selection Jan 26, 2023
@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 26.065% (+0.008%) from 26.057% when pulling cc32ad9 on feature/support-non-modular into bc035e1 on feature/v4.1.

@cristiano-belloni cristiano-belloni requested review from sgb-io, AlbertoBrusa, ayseenver, benpryke and steveukx and removed request for sgb-io January 26, 2023 12:11
AlbertoBrusa
AlbertoBrusa approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@AlbertoBrusa AlbertoBrusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cristiano-belloni cristiano-belloni merged commit b45979e into feature/v4.1 Jan 26, 2023
@cristiano-belloni cristiano-belloni deleted the feature/support-non-modular branch January 26, 2023 13:26
@github-actions github-actions bot mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbertoBrusa AlbertoBrusa AlbertoBrusa approved these changes

@sgb-io sgb-io Awaiting requested review from sgb-io

@ayseenver ayseenver Awaiting requested review from ayseenver

@benpryke benpryke Awaiting requested review from benpryke

@steveukx steveukx Awaiting requested review from steveukx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cristiano-belloni @coveralls @AlbertoBrusa