Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build non-modular workspaces with modular build #2272

Merged
merged 11 commits into from Feb 6, 2023

Conversation

cristiano-belloni
Copy link
Contributor

@cristiano-belloni cristiano-belloni commented Jan 30, 2023

Build non-modular workspaces (i.e. workspaces with no modular field, but with script.build defined in their package.json) by running yarn workspace <package-name> build. Building follows dependency order and non-Modular and Modular builds are seamlessly interleaved.


  • Include non-Modular workspaces in "to-build" ordered list
  • Build them by executing process
  • Tests
  • Update docs with an example

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2023

🦋 Changeset detected

Latest commit: 2a43025

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
modular-scripts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented Jan 30, 2023

Coverage Status

Coverage: 26.015% (-0.05%) from 26.065% when pulling 2a43025 on feature/build-non-modular-workspaces into b45979e on feature/v4.1.

@cristiano-belloni cristiano-belloni marked this pull request as ready for review January 31, 2023 14:51
Copy link
Contributor

@AlbertoBrusa AlbertoBrusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cristiano-belloni cristiano-belloni merged commit e2fa8f4 into feature/v4.1 Feb 6, 2023
@cristiano-belloni cristiano-belloni deleted the feature/build-non-modular-workspaces branch February 6, 2023 10:18
@github-actions github-actions bot mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants