Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix esm-view not starting by downgrading esbuild-loader to 2.x.x #2385

Merged
merged 8 commits into from
May 15, 2023

Conversation

AlbertoBrusa
Copy link
Contributor

@AlbertoBrusa AlbertoBrusa commented May 12, 2023

  • Downgrade esbuild-loader, which fixes starting ESM views in webpack mode. This issue was introduced in Fix esbuild tsconfig bug #2332.
  • Adds a new test to verify starting ESM views in webpack mode (previously, only the esbuild variant was covered).

Since upgrading esbuild-loader did not actually fix the issue in #2332, it is a patch change to roll this back. We will separately address the same issue.

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2023

🦋 Changeset detected

Latest commit: 6f12b3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
modular-scripts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AlbertoBrusa AlbertoBrusa marked this pull request as ready for review May 12, 2023 14:28
@sgb-io
Copy link
Contributor

sgb-io commented May 15, 2023

_ No description provided. _

Suggested description:

  • Downgrade esbuild-loader, which fixes starting ESM views in webpack mode. This issue was introduced in Fix esbuild tsconfig bug #2332.
  • Adds a new test to verify starting ESM views in webpack mode (previously, only the esbuild variant was covered).

Since upgrading esbuild-loader did not actually fix the issue in #2332, it is a patch change to roll this back. We will separately address the same issue.

@AlbertoBrusa AlbertoBrusa merged commit 5ba67bf into jpmorganchase:main May 15, 2023
20 checks passed
@AlbertoBrusa AlbertoBrusa deleted the fix-esm-view-start branch May 15, 2023 14:33
@github-actions github-actions bot mentioned this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants