Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API differences between viewer component and table.view #316

Closed
ColinEberhardt opened this issue Nov 15, 2018 · 1 comment
Closed

API differences between viewer component and table.view #316

ColinEberhardt opened this issue Nov 15, 2018 · 1 comment
Labels
documentation Improvements/bugs/changes to documentation

Comments

@ColinEberhardt
Copy link
Contributor

ColinEberhardt commented Nov 15, 2018

The 'viewer' component uses plurals:

    <perspective-viewer 
        row-pivots='["athlete"]'
        column-pivots='["year"]'>
    </perspective-viewer>

However, tree.view uses singular:

https://github.com/jpmorganchase/perspective/tree/master/packages/perspective#view-1

row_pivot, column_pivot, ...

This really threw me for about half an hour, as mentioned to @neilslinger this morning ;-)

@timkpaine timkpaine added the documentation Improvements/bugs/changes to documentation label Dec 19, 2018
@texodus texodus mentioned this issue Apr 8, 2019
@texodus
Copy link
Member

texodus commented Apr 8, 2019

Thanks for the report - you're right, these are inconsistent. This has been fixed (and made backwards compatible), and will be released in 0.2.22

@texodus texodus closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements/bugs/changes to documentation
Projects
None yet
Development

No branches or pull requests

3 participants