Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #291 Null values in filters #344

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

jburton-scottlogic
Copy link
Contributor

Fixes #291

Added a check to ignore filters where the operand is null or undefined.
Added associated test to check for this functionality.

Added a check to ignore filters where the operand is null or undefined.
Added associated test to check for this functionality.
@texodus
Copy link
Member

texodus commented Dec 19, 2018

Thanks for the PR and test! Please send us a CLA form

I'm inclined to think "x > null" should be an error in the perspective module, and just never submitted in this state from the perspective-viewer module - I made a new issue to capture this #349

@texodus texodus merged commit 0b4fefd into finos:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants