Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publicPath support to webpack-plugin #403

Merged
merged 6 commits into from
Feb 2, 2019
Merged

Add publicPath support to webpack-plugin #403

merged 6 commits into from
Feb 2, 2019

Conversation

LukeSheard
Copy link
Contributor

@LukeSheard LukeSheard commented Jan 31, 2019

Support webpack's publicPath option and add long term caching options into the webpack plugin.

Changes:

  • 42dec1d - update webpack example to be a cross origin asset application
  • 84d8536 - renames the loader filenames for clarity of their real intention
  • fac6af1 - fixes the bug with locating the worker and wasm assets paths when loaded with a publicPath
  • 2e1adfd - adds support for long term caching into the output of the perspective loaders.
  • bc3585c - updates the webpack example to utilize the long term caching webpack options

@@ -55,17 +54,15 @@ exports.default = function loader(content) {
.replace(/(cjs\/js)/, "build");
}
content = fs.readFileSync(inputPath).toString();
if (!options.inline) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes duplicate hashed webworker assets to be output in the Jupyterlab plugin on every build

screen shot 2019-02-01 at 10 08 20 pm

@texodus
Copy link
Member

texodus commented Feb 2, 2019

Thanks for the PR!

Thoroughly tested, fixed one minor regression, but everything else looks good!

@texodus texodus merged commit 02870c6 into master Feb 2, 2019
@texodus texodus deleted the webpack-plugin branch February 2, 2019 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants