D3fc plugin #420
Merged
D3fc plugin #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added default blue color to non-split-by bar graph. - added grid behind split-by bar graph. - ticks and labels on y axis brought into line with highcharts (ticks surrounding bars rather than pointing to them)
- renderChart and renderStackedChart method combined into one. - discrete operations refactored into discrete methods for code legibility.
- improved logic for reading axis labels, particularly in the case that there are multiple. - encapsulated chart config in discrete function for consistency. - moved axis labelling inside styling function.
- remove hardcoded styling of axes' colors. - prevent labels on y axis underlapping data zone.
- also switched crossLabel and mainLabel to be correct
- pass more specific parameters into interpretData function
Preserves the meaning of "crossValue" and "mainValue" so that we'll be able to use those values with the tooltip component without too many changes
The issue was actually with trying to create an empty bar series and associating a tooltip with it, which didn't check that it actually had a node to use.
Separated the scrollable code from the perspective-d3fc code to create a standalone "scrollable" legend component
Implemented X-Y chart
Cleaner axis styling with more readable text More interactive tooltip behaviour
Some styling and tooltip hover changes
redbearsam
changed the title
|
This is exceptionally awesome! We have discussed this offline and agreed to go ahead and merge and publish this plugin as it is already in very useful state - and we're extremely excited about the future of utilizing this plugin as the default for charting in Perspective! For what was clearly a monumental development effort - special thanks @redbearsam @matt-hooper @DevAndyLee @Ro4052 @jacoburton104 for making it happen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: ready for review.
A plugin that uses D3/d3fc as an alternative charting solution to HighCharts.
The plugin is not feature complete. Development continues.
Functionality:
Known issues:
Demonstrating The Plugin:
It should be possible to run the pre-existing examples with the new d3fc chart variants selected. These are called [d3fc] Y Bar Chart and [d3fc] X Bar Chart. There is also a new example accessible from the simple example index page titled Superstore example using D3FC Bar/Column charts that is configured to use the d3fc Y Bar Chart by default.
All changes are within the new perspective-viewer-d3fc package with the exception of: