Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phosphor bindings #436

Merged
merged 5 commits into from
Feb 19, 2019
Merged

Phosphor bindings #436

merged 5 commits into from
Feb 19, 2019

Conversation

texodus
Copy link
Member

@texodus texodus commented Feb 19, 2019

Rebased & cleaned up version of #429

timkpaine and others added 5 commits February 18, 2019 21:39
fix perspective-phosphor instantiation test

phosphor refactor, working on jlab tests

remove console logs

refactor as getters/setters

reenable dark mode

dark mode not working

bugfix

inline import css

remove relatives, working on jlab

remove dep

fixes for jlab plugin, 1 notifyResize still bad

still have 1 extra resize, but ok for now

pass through messages to underlying widget

hide/show bugfix

fewer event listeners, add to classlist dont clobber

Assign id, fix typo, bump to widgets version 1.6.0

bump to widgets 1.6.0

bad link

update yarn.lock, stop yarn clean from failing on missing directories

updates for widgtss
@texodus texodus added in progress enhancement Feature requests or improvements JS Jupyter labels Feb 19, 2019
@texodus texodus mentioned this pull request Feb 19, 2019
@texodus texodus merged commit 265dc62 into master Feb 19, 2019
@texodus texodus deleted the timkpaine-bindings-ts branch February 19, 2019 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements JS Jupyter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants