D3fc plugin - Resizable legend and other tweaks #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k array for greater flexibility
…ize and then expanding again
…ult legend size, add maxsize options
The test is able to create UI elements and then test that what was created is correct. Also added a new `yarn test:unit` command to allow you to easily run just the unit tests in watch mode.
The `{style: "decimal"}` option is ignored for non-float types.
This gives us a more locale suitable formatting of the date.
The test uses the same function to format the date so that it matches.
Implemented an example UI/D3 based unit test
Feature/legend resizable
Don't store theme settings between renders (still put them in settings, but clear and reload when we re-render). Remove remaining references to global "colorStyles" object (always use settings) Calculate `interpolator` from gradient as required, rather than all the time.
Test UI interaction in tooltip component
Support for live theme changes
Use the same color range for all charts when split
"Disable" chart when there is no data
Merge latest jpmorganchase/perspective master changes into develop
update plugin
|
Thanks for the PR! Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the ability for users to resize the legend by dragging the corners or edges. This is in addition to a previous PR that added the ability to move the legend.
There are also some minor changes to the sunburst chart and some additional tests.