Performance overhaul for table.update()
#574
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a number of fixes applied as a result of some runtime profiling of the
table.update()
mechanism:std::unordered_map
in favor oftsl::hopscotch_map
, which improves primary key lookup performance, and overall update processing time is improved by 50%.on_update()
is no longer called 1:1 with calls toupdate()
(though the finalon_update()
will always be consistent withtable
state). As a result,update()
calls will no longer stack up and overwhelm other API calls, which leads to drastic improvement in perceived performance, and much smarter interleaving ofupdate()
and other calls which reflect theview()
to the<perspective-viewer>
element.Additionally, a few other enhancements have been made which facilitated these principal fixes:
yarn test
now respects-t
in focus mode (faster test iteration).