Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row deltas return arrow-serialized data #589

Merged
merged 10 commits into from
May 25, 2019
Merged

Row deltas return arrow-serialized data #589

merged 10 commits into from
May 25, 2019

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented May 24, 2019

When calling view.on_update with the modes parameter set to row, the callback receives an arrow-serialized version of the data from the rows that were updated.

  • on_update mode parameters have been changed to cell and row
  • new get_data methods have been added to each context allowing for data from certain row indices to be returned.
  • to_arrow and col_to_js_typed_array now take options.data_slice, which specifies a custom t_data_slice object from which they will serialize.
  • fill_col_bool now respects undefined and null values for arrow-serialized booleans.
  • t_data_slice has a new constructor which specifies a vector of row indices
  • process_subscribe in host.js now transfers arrow data and respects the arguments that are in its caller. This enables full functionality for on_update mode flags as well as the arrow returned by get_row_delta.

@texodus
Copy link
Member

texodus commented May 25, 2019

Thanks for the PR!

Very cool new feature, and Initial benchmarks look awesome! I have some fixes for issues around practically setting up this example, and an example project for this, which I'll submit in a separate PR.

@texodus texodus merged commit 6b2dd0e into master May 25, 2019
@texodus texodus deleted the row-delta-data branch May 25, 2019 23:26
This was referenced May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants