Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view config class in C++ #672

Merged
merged 6 commits into from
Jul 30, 2019
Merged

Add view config class in C++ #672

merged 6 commits into from
Jul 30, 2019

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Jul 26, 2019

This PR builds on top of the Table class in C++, defining t_view_config: a unified declaration of what a view configuration object looks like, codified in C++ and then implemented in the binding language.

By storing configuration variables (pivots, aggregates, filters, sorts, etc.) as primitive values, we can implement view_config in binding languages without having to construct abstractions that are only used in the engine (such as t_aggspec and t_fterm). This also encapsulates the primitive-to-abstraction conversion code inside t_view_config, reducing the amount of binding code required to construct a view.

C++ changes

  • Adds t_view_config and associated logic
  • Use t_view_config for all View objects, instead of t_config
  • refactors make_view and make_context into templated functions, as their signatures are now much less complex
  • Add [tsl::ordered_map](https://github.com/Tessil/ordered-map) in order to maintain aggregate ordering in the view config
  • Remove unused t_config constructors, reorganize the t_config header, remove t_aggspec_recipe

JS changes

  • Add view_config definition in perspective.js
  • Add utilities to create vectors from Emscripten

@texodus texodus merged commit e03dcd4 into master Jul 30, 2019
@texodus texodus deleted the view-config branch July 30, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants