feature/support private sendRawTransaction #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for raw transactions which can be externally signed by a client of Ethereum node (library such as web3j).
At the moment, there are eth_sendTransaction and eth_sendRawTransaction. This change introduces a new API eth_sendRawPrivateTransaction which allows the externally signed transaction to be sent together with the list of privateFor recipient keys.
Please note in Quorum the private transaction will be replaced with the hash of the encrypted payload. Therefore, in order to use this feature, client would first need to send it to the privacy manager (this is only supported in Tessera) using the
storerawAPI. Details on this API can be found in Tessera wiki https://github.com/jpmorganchase/tessera/wiki/Interface-&-APIExample usage of eth.sendRawPrivateTransaction can be found in docs/api.md within this change