Feature/raw transactions #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trung
reviewed
Dec 4, 2018
| null, null, null, null, null, null, privateFor); | ||
|
|
||
| return new Request<>( | ||
| "eth_sendRawPrivateTransaction", |
There was a problem hiding this comment.
this seems to be a new RPC API in Quorum, can you link the PR in Quorum for this new API?
There was a problem hiding this comment.
Nam just raised the pull request.
Thanks for the refactoring.
When the blk.io team merge their PR we should be able to remove the QuromuRawTransactionManager and use their version.
…re/raw-transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raw (externally signed) transactions acceptance tests.
Depends on the eth_sendRawPrivateTransaction PR on Quorum: Consensys/quorum#591