Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess newlines from migration and GRPC modules #724

Merged
merged 1 commit into from
May 1, 2019
Merged

Remove excess newlines from migration and GRPC modules #724

merged 1 commit into from
May 1, 2019

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented May 1, 2019

Continuation of #699

Applies the EmptyLineSeparator check to the migration and GRPC modules
No functional changes are part of this change.
One logic code change for the following:
- As the ConfigBuilder collects all forwarding keys from provided files, it will put into the final list instead of creating intermediate lists and adding them together. Result is the same in both cases.

  • Removed excess newlines in code
  • Added separation between class members for more readability (not to interfaces)

@codecov-io
Copy link

codecov-io commented May 1, 2019

Codecov Report

Merging #724 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #724      +/-   ##
============================================
- Coverage     99.44%   99.44%   -0.01%     
  Complexity     1890     1890              
============================================
  Files           285      285              
  Lines          5621     5615       -6     
  Branches        284      284              
============================================
- Hits           5590     5584       -6     
  Misses            5        5              
  Partials         26       26
Impacted Files Coverage Δ Complexity Δ
.../java/com/quorum/tessera/client/GrpcP2pClient.java 100% <ø> (ø) 5 <0> (ø) ⬇️
...java/com/quorum/tessera/client/GrpcClientImpl.java 100% <ø> (ø) 7 <0> (ø) ⬇️
...om/quorum/tessera/client/GrpcP2pClientFactory.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...in/java/com/quorum/tessera/grpc/p2p/Convertor.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...rum/tessera/config/migration/LegacyCliAdapter.java 100% <ø> (ø) 19 <0> (ø) ⬇️
...um/tessera/grpc/api/APITransactionGrpcService.java 100% <ø> (ø) 8 <0> (ø) ⬇️
...um/tessera/config/builder/SslTrustModeFactory.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...m/quorum/tessera/config/builder/ConfigBuilder.java 100% <100%> (ø) 38 <0> (ø) ⬇️
...orum/tessera/config/builder/JdbcConfigFactory.java 100% <100%> (ø) 4 <4> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b64a2cf...4dfbaaa. Read the comment docs.

@melowe melowe merged commit 0e39dde into Consensys:master May 1, 2019
@prd-fox prd-fox deleted the style-newlines-grpc branch May 1, 2019 13:56
@Krish1979 Krish1979 added 0.9.3 and removed 0.10.0 labels Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants