Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAVE_STRUCT_TERMIOX definition prevents android build on newer Kotlin and Gradle versions. #84

Closed
wants to merge 7 commits into from

Conversation

ajeeshklr
Copy link
Contributor

HAVE_STRUCT_TERMIOX definition for android is failing build generation for android for the following Kotlin and Gradle versions.

This is similar to the issue #50

Kotlin version from build.gradle

buildscript {
ext.kotlin_version = '1.8.0'
repositories {
google()
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
}

gradle-wrapper.properties
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip

The following code snippet resolves the compilation issue.

android/libserialport/config.h
undef HAVE_STRUCT_TERMIOX

This merge request also contains changes for supporting libserialport 0.3 and the latest flutter_libserialport in pub.
Yaml file is merged with relevant changes.

Functionality of the library is verified in real hardware with these changes.

@ajeeshklr ajeeshklr marked this pull request as ready for review July 21, 2023 08:55
@pro100andrey pro100andrey mentioned this pull request Aug 28, 2023
@rekire
Copy link

rekire commented Sep 27, 2023

You might want to rollback the line ending changes, which are a bit noise in your PR

@guyluz11
Copy link

This pr solves the build Thanks :D

Unfortunately, now we are stuck on the permission error as a blocker, Permission denied, errno = 13 you didn't get it?.

@lucafabbri lucafabbri closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants