Run tests against all recent Java versions and migrate tests to junit5. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshilliard
changed the title
ar
reviewed
Jul 15, 2019
| public void setUp () throws Exception { | ||
| super.setUp(); |
There was a problem hiding this comment.
why do you delete calls to super.setUp() where the proper GLSession (with the right name for the tests) get initialized?
There was a problem hiding this comment.
Isn't that unnecessary due to the TestBase changes?
jameshilliard
commented
Jul 15, 2019
jameshilliard
force-pushed
the
java-update
branch
from
8c3caa4
to
d3338d6
Compare
|
You should not use the same method names :) if you want to do that then use
super. Xxx
…On Mon, Jul 15, 2019, 4:08 PM Alejandro Revilla ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In modules/minigl/src/test/java/org/jpos/gl/TestBase.java
<#108 (comment)>:
> protected GLSession gls;
protected long start;
protected long checkpoint;
+ @beforeeach
I have to agree with Andres here, IDE also can deal with calls to super,
and copy & paste can land you using the same name, as we just saw.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#108?email_source=notifications&email_token=AAEQ32L6ZG77BYXOA2TC2O3P7TKK7A5CNFSM4IDPZKPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6PIDSY#discussion_r303612988>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEQ32N5O4DPGODWJZ4FLZTP7TKK7ANCNFSM4IDPZKPA>
.
|
|
Yeah, I missed that during my initial conversion pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.