Feature/negate op in environment expressions #519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this is equivalent to PR #518 done against current
master
)Add support for environment expressions with a negate/NOT operator, such as
${!server.enabled:false}
Extensive test cases have been added.
Some observations:
true/false/yes/no
, or their string equivalents (upper/lowercase))."true"
/"false"
ortrue
/false
(depending on the retrieval throughEnvironment.get()
orSimpleConfiguration#getBoolean()
)SimpleConfiguration#getBoolean()
an undefined property always resolves asfalse
(original behavior).Therefore, when negating an undefined property,
getBoolean()
will return truegetBoolean()
on${!__undefined__:true}
will returntrue
, and if callingEnvironment.get()
directly, it will return the string"true"
)