Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kerberos login support #42

Closed
dimon222 opened this issue Nov 9, 2018 · 4 comments
Closed

Kerberos login support #42

dimon222 opened this issue Nov 9, 2018 · 4 comments

Comments

@dimon222
Copy link
Contributor

dimon222 commented Nov 9, 2018

There's an auth module for requests that can make this happen. Any chance atlasclient can get support of switching auth to kerberos?
https://github.com/requests/requests-kerberos

@jpoullet2000
Copy link
Owner

Hi dimon22... it is indeed certainly an interesting/important feature to have for this client. Probably a few modifs in the request method should make it work. However, I'd like to test it in a real env with a kerberized atlas before pushing. So far, I'm mocking all the requests. Would you agree to test it in a real environment? Another way would be to set up a true Hadoop + Kerberized Atlas env when testing... if you have any suggestion about it I'd be interested as well.

@dimon222
Copy link
Contributor Author

@jpoullet2000 I gave it a look, and I think there's even easier way. Potentially requests.Session object allows auth attribute to be set to switch auth globally for all requests done with it.
http://docs.python-requests.org/en/master/api/#requests.Session.auth

If we just plug new auth in Session after instantiating Session in constructor of HttpClient, that should be it!

self.session = requests.Session()

I'll give it a try in kerberized environment.

@jpoullet2000
Copy link
Owner

jpoullet2000 commented Dec 3, 2018 via email

@dimon222
Copy link
Contributor Author

Sadly, I no longer have kerberized environment in my possession :(
I prepared PR with necessary change for custom Auth support if anyone gets a chance to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants