New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kerberos login support #42
Comments
Hi dimon22... it is indeed certainly an interesting/important feature to have for this client. Probably a few modifs in the request method should make it work. However, I'd like to test it in a real env with a kerberized atlas before pushing. So far, I'm mocking all the requests. Would you agree to test it in a real environment? Another way would be to set up a true Hadoop + Kerberized Atlas env when testing... if you have any suggestion about it I'd be interested as well. |
@jpoullet2000 I gave it a look, and I think there's even easier way. Potentially requests.Session object allows auth attribute to be set to switch auth globally for all requests done with it. If we just plug new auth in Session after instantiating Session in constructor of HttpClient, that should be it! atlasclient/atlasclient/client.py Line 127 in 68fb8a6
I'll give it a try in kerberized environment. |
Thanks Dmitry. I'd be glad to accept your pull request.
Le jeu. 15 nov. 2018 à 04:15, Dmitry Romanenko <notifications@github.com> a
écrit :
… @jpoullet2000 <https://github.com/jpoullet2000> I gave it a look, and I
think there's even easier way. Potentially requests.Session object allows
auth attribute to be set to switch auth globally for all requests done with
it.
http://docs.python-requests.org/en/master/api/#requests.Session.auth
If we just plug new auth in Session after instantiating Session in
constructor of HttpClient, that should be it!
https://github.com/jpoullet2000/atlasclient/blob/68fb8a6ea3a9033f019e24fa61b439cb592be82b/atlasclient/client.py#L127
I'll give it a try in kerberized environment.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AApyHqEqQruVdafC0d8eQQngClkuPEtlks5uvNxOgaJpZM4YWold>
.
|
Sadly, I no longer have kerberized environment in my possession :( |
There's an auth module for requests that can make this happen. Any chance atlasclient can get support of switching auth to kerberos?
https://github.com/requests/requests-kerberos
The text was updated successfully, but these errors were encountered: