Run clean up in a separate task #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what that Appveyor failure is about 🤔 Seems like something's messed up with Appveyor's npm? |
3 tasks
|
Awesome, let's try it! Thanks! |
|
Thank you! |
|
Landed in 3.5.0 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing the same thing #103 was trying to address. See also electron/electron#9583, electron/electron#8685 and #98.
The root of the problem is that
electron-mochawould try to delete Electron'suserDatadirectory out from under it while it was still running. That happened to work sometimes, but as those issues show, it's pretty fragile.Instead, we could spawn a separate task to clean up after Electron's quit.