Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable power save app suspension #129

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Disable power save app suspension #129

merged 1 commit into from
Jun 7, 2018

Conversation

julianhille
Copy link
Contributor

Long running tests or test that need to wait for a given time could lead to the OS suspend the app or reduce its cpu time.
This leads to lesser precision for setTimeout or setInterval execution.

Fixes #128

Long running tests or test that need to wait for a given time could lead to the OS suspend the app or reduce its cpu time.
This leads to lesser precision for `setTimeout` or `setInterval` execution.
@inukshuk
Copy link
Collaborator

inukshuk commented Jun 7, 2018

Looks great, thanks!

@inukshuk inukshuk merged commit 1e3dbe1 into jprichardson:master Jun 7, 2018
@julianhille
Copy link
Contributor Author

Thanks for fast review/merge/release!

@inukshuk
Copy link
Collaborator

inukshuk commented Jun 7, 2018

By the way, I think timing issues may get worse with background throttling being added to Chrome (not sure exactly which version of Electron this applies to, but you can use a command line switch to turn it off).

@julianhille
Copy link
Contributor Author

You are right, this will only apply to the renderer process right?
But these should be set: --disable-background-timer-throttling and maybe also: --disable-renderer-backgrounding

@inukshuk
Copy link
Collaborator

inukshuk commented Jun 7, 2018

Yeah, that's my best guess also, not having played around with this. If you notice issues, you can set command line switches using the --require-main hook of Electron-Mocha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants