Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End electron with correct exit code #17

Merged
merged 2 commits into from
Oct 21, 2015

Conversation

FWeinb
Copy link
Contributor

@FWeinb FWeinb commented Oct 17, 2015

I just did some testing of process.exit(1) in various versions of electron:

0.33.0 ×
0.33.1 ×
0.33.2 ×
0.33.3 ×
0.33.4 ×
0.33.5 ×
0.33.6 ×
0.33.7 ✔
0.33.8 ✔
0.34.0 ✔

So basically this is working for electron >= 0.33.7
Should I include a test for the electron version to ensure that electron-mocha is only started with a working electron version?

@jprichardson jprichardson mentioned this pull request Oct 17, 2015
@jprichardson
Copy link
Owner

Please remove the semicolon. No need to check for electron version.

@FWeinb
Copy link
Contributor Author

FWeinb commented Oct 18, 2015

Sorry for the delay, I removed the semicolon.

jprichardson added a commit that referenced this pull request Oct 21, 2015
End electron with correct exit code
@jprichardson jprichardson merged commit b8ab693 into jprichardson:master Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants