Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc things + squash deprecation warning #26

Merged
merged 1 commit into from
Nov 26, 2015
Merged

Misc things + squash deprecation warning #26

merged 1 commit into from
Nov 26, 2015

Conversation

Mingling94
Copy link
Contributor

*Removed index.js as it wasn't useful, repointed index.html to run.js
*Everywhere that requires an electron module first checks electron's version to apply proper syntax

This gets rid of a deprecation warning upon use
@Mingling94
Copy link
Contributor Author

@jprichardson boop

@Mingling94
Copy link
Contributor Author

@jprichardson aight, not quite sure what you meant but index.js is back

jprichardson added a commit that referenced this pull request Nov 26, 2015
Misc things + squash deprecation warning
@jprichardson jprichardson merged commit af0369a into jprichardson:master Nov 26, 2015
@jprichardson
Copy link
Owner

Awesome, thanks!

@jviotti
Copy link
Contributor

jviotti commented Nov 30, 2015

@Mingling94 @jprichardson I'm on v0.35.2 and this changes are not working correctly.

More specifically, electron.ipcMain doesn't exist here (despite being mentioned in the documentation), and I get the following error when running a test on the renderer context:

screenshot 2015-11-30 10 57 57

The error is reproducible by running any of the tests with --renderer.

I'll add a fix by checking for the existence of electron.ipcMain as part of the v0.35 check.

@Mingling94
Copy link
Contributor Author

My bad, it should have been electron.ipcRenderer

@jviotti
Copy link
Contributor

jviotti commented Nov 30, 2015

@Mingling94 Oh yeah, I didn't notice that. I can update my PR with those changes if you wish.

@Mingling94
Copy link
Contributor Author

@jviotti do so! Alternatively, I'm submitting a PR that does the correct require statement based on try-catch statements and it will be up to @jprichardson which looks more maintainable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants