Add a --require-main option #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ | |||
| "description": "Mocha tests in Electron.", | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "test": "standard && node bin/electron-mocha test/main && node bin/electron-mocha --renderer test/renderer", | |||
| "test": "standard && node bin/electron-mocha test/main --require-main test/support/requireMain && node bin/electron-mocha --renderer test/renderer --require-main test/support/requireMain", | |||
There was a problem hiding this comment.
Can you add these to test/mocha.opts instead?
There was a problem hiding this comment.
Yep 👍 Missed that file 😆
|
Agreed, that's a useful option. Can you add it to the readme as well? @jprichardson if @MarshallOfSound is interested, I'd suggest to add him as a collaborator :) |
MarshallOfSound
force-pushed
the
master
branch
3 times, most recently
from
8290d9d
to
237ff7d
Compare
…when testing in the renderer process
This sounds good to me. @MarshallOfSound what say you? |
|
@jprichardson Always happy to jump on board 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow loading main process test utils when testing in the renderer process. Mocking the
remotemodule in electron is iffy at the best of times so if we can require modules in the main process to help us mock the actual main process implementation it will make testing things in the renderer a lot easier 👍