Remove uncaught exception errors #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mocha registers exception handlers (work in main and renderer) to handle async test failures. Fix #93
|
LGTM. Possible breaking change? |
|
I just realized that we should retain the error handling for supporting modules ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocha registers exception handlers (work in main and renderer) to handle async test failures. If we handle uncaught exceptions (and exit) the test suite will not run to completion. See #93
I think the best approach is actually for us to not handle uncaught errors at all since Mocha will handle them anyway. I have not had time to add tests for this (would be nice, but requires some effort, because it would have to be an integration test to be useful really). But I tested this with some of my own projects and made sure that if I throw errors in a test or hook they're picked up, so I hope this is good to merge.