Merge pull request #402 from jprichardson/spaces

BREAKING: Remove support for setting spaces for JSON writing
jprichardson · Apr 10, 2017 · 2a4ec71 · 2a4ec71
2 parents b549b04 + c0f56ee
commit 2a4ec71
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 53 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -24,14 +24,3 @@ assign(fs, require('./ensure'))
 assign(fs, require('./output'))
 
 module.exports = fs
-
-// maintain backwards compatibility for awhile
-const jsonfile = {}
-Object.defineProperty(jsonfile, 'spaces', {
-  get: () => fs.spaces, // found in ./json
-  set: val => {
-    fs.spaces = val
-  }
-})
-
-module.exports.jsonfile = jsonfile // so users of fs-extra can modify jsonFile.spaces
diff --git a/lib/json/__tests__/jsonfile-integration.test.js b/lib/json/__tests__/jsonfile-integration.test.js
@@ -25,15 +25,10 @@ describe('jsonfile-integration', () => {
         lastName: 'Richardson'
       }
 
-      const oldSpaces = fse.jsonfile.spaces
-      fse.jsonfile.spaces = 4
-
       const file = path.join(TEST_DIR, 'file.json')
       fse.writeJsonSync(file, obj1)
       const data = fs.readFileSync(file, 'utf8')
-      assert.strictEqual(data, JSON.stringify(obj1, null, 4) + '\n')
-
-      fse.jsonfile.spaces = oldSpaces
+      assert.strictEqual(data, JSON.stringify(obj1) + '\n')
     })
   })
 })
diff --git a/lib/json/__tests__/spaces.test.js b/lib/json/__tests__/spaces.test.js
diff --git a/lib/json/jsonfile.js b/lib/json/jsonfile.js
@@ -11,6 +11,5 @@ module.exports = {
   writeJson: jsonFile.writeFile,
   writeJSON: jsonFile.writeFile,
   writeJsonSync: jsonFile.writeFileSync,
-  writeJSONSync: jsonFile.writeFileSync,
-  spaces: 2 // default in fs-extra
+  writeJSONSync: jsonFile.writeFileSync
 }