copy & copySync: handle case-insensitive paths, check paths stricter …

…before copying

lib/copy-sync/__tests__/copy-sync-case-insensitive-paths.test.js

@@ -0,0 +1,131 @@
+'use strict'
+
+const assert = require('assert')
+const os = require('os')
+const path = require('path')
+const fs = require(process.cwd())
+
+/* global beforeEach, afterEach, describe, it */
+
+describe('+ copySync() - case insensitive paths', () => {
+  let TEST_DIR = ''
+  let src = ''
+  let dest = ''
+
+  beforeEach(done => {
+    TEST_DIR = path.join(os.tmpdir(), 'fs-extra', 'copy-sync-case-insensitive-paths')
+    fs.emptyDir(TEST_DIR, done)
+  })
+
+  afterEach(done => fs.remove(TEST_DIR, done))
+
+  describe('> when src is a directory', () => {
+    it('should behave correctly based on the OS', () => {
+      src = path.join(TEST_DIR, 'srcdir')
+      fs.outputFileSync(path.join(src, 'subdir', 'file.txt'), 'some data')
+      dest = path.join(TEST_DIR, 'srcDir')
+      let errThrown = false
+
+      try {
+        fs.copySync(src, dest)
+      } catch (err) {
+        if (os === 'darwin' || os === 'win32') {
+          assert.strictEqual(err.message, 'Source and destination must not be the same.')
+          assert(fs.existsSync(src))
+          assert(!fs.existsSync(dest))
+          errThrown = true
+        }
+      }
+      if (os === 'darwin' || os === 'win32') assert(errThrown)
+      if (os === 'linux') {
+        assert(fs.existsSync(dest))
+        assert.strictEqual(fs.readFileSync(path.join(dest, 'subdir', 'file.txt'), 'utf8'), 'some data')
+        assert(!errThrown)
+      }
+    })
+  })
+
+  describe('> when src is a file', () => {
+    it('should behave correctly based on the OS', () => {
+      src = path.join(TEST_DIR, 'srcfile')
+      fs.outputFileSync(src, 'some data')
+      dest = path.join(TEST_DIR, 'srcFile')
+      let errThrown = false
+
+      try {
+        fs.copySync(src, dest)
+      } catch (err) {
+        if (os === 'darwin' || os === 'win32') {
+          assert.strictEqual(err.message, 'Source and destination must not be the same.')
+          assert(fs.existsSync(src))
+          assert(!fs.existsSync(dest))
+          errThrown = true
+        }
+      }
+      if (os === 'darwin' || os === 'win32') assert(errThrown)
+      if (os === 'linux') {
+        assert(fs.existsSync(dest))
+        assert.strictEqual(fs.readFileSync(dest, 'utf8'), 'some data')
+        assert(!errThrown)
+      }
+    })
+  })
+
+  describe('> when src is a symlink', () => {
+    it('should behave correctly based on the OS, symlink dir', () => {
+      src = path.join(TEST_DIR, 'srcdir')
+      fs.outputFileSync(path.join(src, 'subdir', 'file.txt'), 'some data')
+      const srcLink = path.join(TEST_DIR, 'src-symlink')
+      fs.symlinkSync(src, srcLink, 'dir')
+      dest = path.join(TEST_DIR, 'srcDir')
+      let errThrown = false
+
+      try {
+        fs.copySync(src, dest)
+      } catch (err) {
+        if (os === 'darwin' || os === 'win32') {
+          assert.strictEqual(err.message, 'Source and destination must not be the same.')
+          assert(fs.existsSync(src))
+          assert(!fs.existsSync(dest))
+          errThrown = true
+        }
+      }
+      if (os === 'darwin' || os === 'win32') assert(errThrown)
+      if (os === 'linux') {
+        assert(fs.existsSync(dest))
+        assert.strictEqual(fs.readFileSync(path.join(dest, 'subdir', 'file.txt'), 'utf8'), 'some data')
+        const link = fs.readlinkSync(srcLink)
+        assert.strictEqual(link, dest)
+        assert(!errThrown)
+      }
+    })
+
+    it('should behave correctly based on the OS, symlink file', () => {
+      src = path.join(TEST_DIR, 'srcfile')
+      fs.outputFileSync(src, 'some data')
+      const srcLink = path.join(TEST_DIR, 'src-symlink')
+      fs.symlinkSync(src, srcLink, 'file')
+      dest = path.join(TEST_DIR, 'srcFile')
+      let errThrown = false
+
+      try {
+        fs.copySync(src, dest)
+      } catch (err) {
+        if (os === 'darwin' || os === 'win32') {
+          assert.strictEqual(err.message, 'Source and destination must not be the same.')
+          assert(fs.existsSync(src))
+          assert(!fs.existsSync(dest))
+          errThrown = true
+        }
+      }
+      if (os === 'darwin' || os === 'win32') assert(errThrown)
+      if (os === 'linux') {
+        assert(fs.existsSync(dest))
+        assert.strictEqual(fs.readFileSync(dest, 'utf8'), 'some data')
+        const link = fs.readlinkSync(srcLink)
+        assert.strictEqual(link, dest)
+        assert(!errThrown)
+      }
+    })
+  })
+})

lib/copy-sync/__tests__/copy-sync-dir.test.js

@@ -20,7 +20,7 @@ describe('+ copySync()', () => {
     fs.emptyDir(TEST_DIR, done)
   })
 
-  describe('> when the source is a directory', () => {
+  describe('> when src is a directory', () => {
     describe('> when dest exists and is a file', () => {
       it('should throw error', () => {
         const src = path.join(TEST_DIR, 'src')

lib/copy-sync/__tests__/copy-sync-file.test.js

@@ -20,7 +20,7 @@ describe('+ copySync()', () => {
 
   afterEach(done => fs.remove(TEST_DIR, done))
 
-  describe('> when the source is a file', () => {
+  describe('> when src is a file', () => {
     it('should copy the file synchronously', () => {
       const fileSrc = path.join(TEST_DIR, 'TEST_fs-extra_src')
       const fileDest = path.join(TEST_DIR, 'TEST_fs-extra_copy')
@@ -104,7 +104,7 @@ describe('+ copySync()', () => {
       })
     })
 
-    describe('> when the source file does not have write permissions', () => {
+    describe('> when src file does not have write permissions', () => {
       it('should be able to copy contents of file', () => {
         const fileSrc = path.join(TEST_DIR, 'file.txt')
         const fileDest = path.join(TEST_DIR, 'file-copy.txt')

lib/copy-sync/__tests__/copy-sync-prevent-copying-identical.test.js

@@ -35,9 +35,9 @@ describe('+ copySync() - prevent copying identical files and dirs', () => {
   //  src is symlink, dest is regular
   //  src is symlink, dest is symlink
 
-  describe('> when the source is a directory', () => {
+  describe('> when src is a directory', () => {
     describe(`>> when src is regular and dest is a symlink that points to src`, () => {
-      it('should not copy and return', () => {
+      it('should error', () => {
         src = path.join(TEST_DIR, 'src')
         fs.mkdirsSync(src)
         const subdir = path.join(TEST_DIR, 'src', 'subdir')
@@ -49,7 +49,11 @@ describe('+ copySync() - prevent copying identical files and dirs', () => {
 
         const oldlen = klawSync(src).length
 
-        fs.copySync(src, destLink)
+        try {
+          fs.copySync(src, destLink)
+        } catch (err) {
+          assert.strictEqual(err.message, 'Source and destination must not be the same.')
+        }
 
         const newlen = klawSync(src).length
         assert.strictEqual(newlen, oldlen)
@@ -117,17 +121,21 @@ describe('+ copySync() - prevent copying identical files and dirs', () => {
   //  src is symlink, dest is regular
   //  src is symlink, dest is symlink
 
-  describe('> when the source is a file', () => {
+  describe('> when src is a file', () => {
     describe(`>> when src is regular and dest is a symlink that points to src`, () => {
-      it('should not copy and return', () => {
+      it('should error', () => {
         src = path.join(TEST_DIR, 'src', 'somefile.txt')
         fs.ensureFileSync(src)
         fs.writeFileSync(src, 'some data')
 
         const destLink = path.join(TEST_DIR, 'dest-symlink')
         fs.symlinkSync(src, destLink, 'file')
 
-        fs.copySync(src, destLink)
+        try {
+          fs.copySync(src, destLink)
+        } catch (err) {
+          assert.strictEqual(err.message, 'Source and destination must not be the same.')
+        }
 
         const link = fs.readlinkSync(destLink)
         assert.strictEqual(link, src)