Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Windows invalid directory name causes infinite loop in ensureDir(). #209

Closed
vzakon opened this issue Jan 7, 2016 · 1 comment
Closed

Comments

@vzakon
Copy link

vzakon commented Jan 7, 2016

Example:
require('fs-extra').ensureDir("./bad?dir", function(err) { console.log("never here!"); });

Infinite recursion call is here:
https://github.com/jprichardson/node-fs-extra/blob/master/lib/mkdirs/mkdirs.js#L33

@jprichardson
Copy link
Owner

Thanks for reporting. I'd like to drop my custom mkdirp and go back to using https://github.com/substack/node-mkdirp again, but looks like it's still affected: https://github.com/substack/node-mkdirp/issues/70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants