Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node v10 support #886

Closed
RyanZim opened this issue Apr 3, 2021 · 2 comments
Closed

Drop Node v10 support #886

RyanZim opened this issue Apr 3, 2021 · 2 comments
Labels
Milestone

Comments

@RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented Apr 3, 2021

Node v10 EOLs on 2021-04-30; here's a list of things we can do when we drop support for Node v10:

  • fs.promises special handling not needed:
    // Export fs.promises as a getter property so that we don't trigger
    // ExperimentalWarning before fs.promises is actually accessed.
    const fs = require('fs')
    if (Object.getOwnPropertyDescriptor(fs, 'promises')) {
    Object.defineProperty(module.exports, 'promises', {
    get () { return fs.promises }
    })
    }
    &
    if (key === 'promises') {
    // fs.promises is a getter property that triggers ExperimentalWarning
    // Don't re-export it here, the getter is defined in "lib/index.js"
    return
    }
  • mkdirs can use native fs.mkdir with recursive option everywhere
    const useNativeRecursiveOption = atLeastNode('10.12.0')
  • No special handling to avoid bigint usage
    const nodeSupportsBigInt = atLeastNode('10.5.0')
    &
    const NODE_VERSION_WITH_BIGINT = '10.5.0'
@RyanZim RyanZim added the meta label Apr 3, 2021
@JPeer264
Copy link
Collaborator

@JPeer264 JPeer264 commented Apr 9, 2021

Also do not forget to update the engines package.json

"engines": {
"node": ">=10"
},

If #881 is not yet implemented by this time Node10 got dropped and .travis,yml is still in, it should be updated as well (same with appveyor)

- nodejs_version: "10"

- 10
- 11

RyanZim added a commit that referenced this issue Apr 22, 2021
Refs #886
RyanZim added a commit that referenced this issue Apr 29, 2021
Refs #886
@RyanZim RyanZim added this to the 10.0.0 milestone Apr 29, 2021
RyanZim added a commit that referenced this issue Apr 30, 2021
* Remove special handling of fs.promises

Refs #886

* Fix tests
RyanZim added a commit that referenced this issue Apr 30, 2021
Refs #886
@RyanZim
Copy link
Collaborator Author

@RyanZim RyanZim commented Apr 30, 2021

Done in #893, #890, #894, & #895.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants