Handle EEXIST error when clobbering dir #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprichardson
added a commit
that referenced
this pull request
May 8, 2015
…lobbering-dir Handle EEXIST error when clobbering dir
|
Thanks for this! Btw, which Node.js version and Linux version did you notice this behavior? |
|
Thanks for merging. It was on Travis's container infrastructure. Reading Travis's output, seems that is Ubuntu 12.04.5 LTS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some versions of Linux (including on the Travis container infrastructure) throw an EEXIST error rather than ENOTEMPTY when you try to overwrite a directory while renaming, and that wasn't being handled.
This PR fixes that.