-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES6 refactor #360
ES6 refactor #360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, noticed one old comment that could be removed.
lib/ensure/symlink-paths.js
Outdated
var path = require('path') | ||
'use strict' | ||
|
||
const path = require('path') | ||
// path.isAbsolute shim for Node.js 0.10 support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort of unrelated, but this comment should have been removed earlier, wouldn't hurt to remove it here.
I'm fine with doing the skipped files, all of them are already significantly modified from their original state. If we decide to make changes in #292, you could skip |
@RyanZim I am on EDIT: |
BTW, don't bother with |
@RyanZim is this ready to merge? |
Merged. @JPeer264 Thanks again for all your work here. |
(#355 ) I did some more refactoring. Now everything except
move/index
,copy/ncp
andremove/rimraf
are as much as possible refactored to ES6. I wasn't sure on the skipped files, as they are from another library or got a comment with something likeneeds rewrite
or similar.