Run stricter linter to cleanup problems and force ES6 usage #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPeer264
previously requested changes
Apr 9, 2018
|
|
||
| const argv = require('minimist')(process.argv.slice(2)) | ||
|
|
||
| const mochaOpts = assign({ | ||
| const mochaOpts = Object.assign({ |
There was a problem hiding this comment.
How about:
const mochaOpts = {
...argv,
ui: 'bdd',
reporter: 'dot',
timeout: 30000
};There was a problem hiding this comment.
@JPeer264 That's object spread properties; which are only supported in Node 8+, so we can't use those yet. Someday, though...
There was a problem hiding this comment.
Oh dang! I guess I am using too much babel in my projects. Good to know though ;)
JPeer264
reviewed
Apr 9, 2018
lib/fs/index.js
Outdated
| return fs.write(fd, buffer, a, b, c, callback) | ||
| exports.write = function (fd, buffer, ...args) { | ||
| if (typeof args[args.length - 1] === 'function') { | ||
| return fs.write(fd, buffer, ...args) | ||
| } | ||
|
|
||
| // Check for old, depricated fs.write(fd, string[, position[, encoding]], callback) | ||
| if (typeof buffer === 'string') { | ||
| return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
This here is actually code duplication now, and this return is not any different than to the other one.
I think we can leave that if, because here it does not make the difference if there are two or three arguments. Thoughts?
There was a problem hiding this comment.
You're right; will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started work to use rest/spread operators, since they're supported in Node 6+. Along the way, I discovered and fixed a few more problems, like regular functions being used instead of arrow functions, missing
'use strict'statements, usingletinstead ofconst, aswitchwhereif/elsedoes the job fine, etc.write()'s promise implementation inlib/fs/index.jsrequired heavy refactoring to avoid usingarguments, please review this carefully.I also discovered that we're still using our own ponyfill for
Object.assign(), despite the fact it's now well supported in Node. So I removed that, and refactoredlib/index.jswhile I was at it.