Remove check for fs.realpath.native support, since it's everywhere #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPeer264
approved these changes
Apr 6, 2021
geralfonso
pushed a commit
to geralfonso/node-fs-extra
that referenced
this pull request
Jan 5, 2022
…where (jprichardson#887)" This reverts commit f4a880d.
This was referenced Apr 5, 2022
RyanZim
added a commit
that referenced
this pull request
Apr 16, 2022
* Revert "Remove check for fs.realpath.native support, since it's everywhere (#887)" This reverts commit f4a880d. * Added warning and fallback support for missing fs.realpath.native Signed-off-by: Lam Wei Li <peteriman@mail.com> * Removed NodeJS check and fs.realpath.native fallback Signed-off-by: Lam Wei Li <peteriman@mail.com> * Leaving original listener intact during test and better phasing for warning Signed-off-by: Lam Wei Li <peteriman@mail.com> * Using done() for proper async test Signed-off-by: Lam Wei Li <peteriman@mail.com> * Updated comments for clarity Co-authored-by: Ryan Zimmerman <17342435+RyanZim@users.noreply.github.com> Co-authored-by: Ryan Zimmerman <17342435+RyanZim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.