Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: "sideEffects": false #941

Merged
merged 1 commit into from Feb 21, 2022
Merged

chore: "sideEffects": false #941

merged 1 commit into from Feb 21, 2022

Conversation

jacob-ebey
Copy link
Contributor

@jacob-ebey jacob-ebey commented Feb 18, 2022

Add "sideEffects": false to package.json to allow frameworks that mix client and server code in the same files to tree-shake out fs-extra from client bundles.

Add `"sideEffects": false` to package.json to allow frameworks that mix client and server code in the same files to tree-shake out fs-extra from client bundles.
@RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented Feb 18, 2022

I've never heard of this key; what bundlers use it? Where's it documented?

@RyanZim RyanZim merged commit 9568a69 into jprichardson:master Feb 21, 2022
15 checks passed
@jacob-ebey
Copy link
Contributor Author

@jacob-ebey jacob-ebey commented Feb 21, 2022

🎉🥳 Thank you! When can we look forward to a release?

@RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented Feb 22, 2022

Published v10.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants