Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Workflows security hardening #985

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

sashashura
Copy link
Contributor

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.
It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

Signed-off-by: Alex <aleksandrosansan@gmail.com>
@RyanZim
Copy link
Collaborator

RyanZim commented Dec 8, 2022

Don't think this really matters, there's no possibility of injection here, and if GH's official actions get compromised, this is the least of our problems. Don't suppose it hurts either, though.

@sashashura
Copy link
Contributor Author

sashashura commented Dec 8, 2022

It is not really about injection, although running with the least privileges is always desirable. See my comment here ladjs/superagent#1756 (comment)

@RyanZim RyanZim merged commit 2b5c083 into jprichardson:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants