Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writefile with serialisation error but no callback writes empty file #81

Closed
bergus opened this issue Jun 15, 2017 · 2 comments
Closed
Assignees
Labels

Comments

@bergus
Copy link

bergus commented Jun 15, 2017

I'm pretty certain the line

if (callback) return callback(err, null)

in that catch block should be

if (callback) callback(err, null)
return
@RyanZim
Copy link
Collaborator

RyanZim commented Jun 15, 2017

@bergus You're right; can you submit a PR?

@RyanZim RyanZim added the bug label Jun 15, 2017
@bergus
Copy link
Author

bergus commented Jun 29, 2017

Nah, not interested, I was just looking at the code for this SO question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants