Add EOL at EOF #14
Merged
Add EOL at EOF #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write a newline character at the end of the file written, because EOL should be treated as "line terminator", not "line separator".
|
Awesome, thank you! This is technically a breaking change so I'll be upgrading Thanks :) |
|
Published 2.0.0. Thanks again! |
|
Thank you for releasing the change. Could you please modify node-fs-extra to use the new jsonfile version too? At the moment, the dependency is |
|
Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write a newline character at the end of the file written, because
EOL should be treated as "line terminator", not "line separator".
Close #13.