Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

support append file #37

Closed
wants to merge 1 commit into from
Closed

support append file #37

wants to merge 1 commit into from

Conversation

796F
Copy link

@796F 796F commented Nov 7, 2015

untested support for appending to file.

using it just fine, but might break dunno 馃悪

@jprichardson
Copy link
Owner

Related: #23

With no tests, there's zero chance of this getting accepted.

I still have reservations regarding point 2 from #23:

I'm wondering if it'd be confusing that readFile, writeFile are used in the context of one JSON object (one JSON record), whereas appendFile would imply appending another JSON object, i.e. this JSON file would have multiple JSON objects (multiple JSON records). Would this be confusing? Is there a standard / mime-type of newline delimited JSON?

I've since learned there's ndjson and jsonnl standards. If you add tests, I'm still reluctant to accept this. Mainly because of the two different paradigms: writeFile is one JSON object, appendFile is many. What should readFile do then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants