Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors no longer caught #37

Open
stevenvachon opened this issue Jul 13, 2017 · 3 comments
Open

Errors no longer caught #37

stevenvachon opened this issue Jul 13, 2017 · 3 comments

Comments

@stevenvachon
Copy link
Contributor

stevenvachon commented Jul 13, 2017

Before, I would console.error(error); process.exitCode = 1 and the "error" event would be emitted. This is no longer happening now that I'm not using v0.6.2 from npm

microsoft/node-pty#71

@stevenvachon
Copy link
Contributor Author

The node-pty guys have no intention of fixing this. Should we remove the error event, then, or is there a need to emit stream errors?

@piranna
Copy link
Collaborator

piranna commented Jul 29, 2017 via email

@stevenvachon
Copy link
Contributor Author

There is a link in the original comment.

This was referenced Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants