New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose string.js as AMD #20

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@eduardo-matos

eduardo-matos commented Dec 5, 2012

Added support for AMD.

I've manually tested this feature with RequireJS and Dojo Toolkit, and everything worked as expected.

I'd be glad if you help me to test this! 馃槄

@eduardo-matos

This comment has been minimized.

Show comment
Hide comment
@eduardo-matos

eduardo-matos Dec 5, 2012

Owner

Intentionally left window.S as a global function because third party application may have a global function called window.define and do not make use of any AMD loader.

Owner

eduardo-matos commented on lib/string.js in a99eccc Dec 5, 2012

Intentionally left window.S as a global function because third party application may have a global function called window.define and do not make use of any AMD loader.

@jprichardson

This comment has been minimized.

Show comment
Hide comment
@jprichardson

jprichardson Jan 15, 2013

Owner

Merging code locally. Will be updated shortly.

Owner

jprichardson commented Jan 15, 2013

Merging code locally. Will be updated shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment