New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyrillic support. #46

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@yumitsu
Contributor

yumitsu commented Jun 11, 2013

It should cover Russian, Ukrainian and Belarusian languages. Related to #43.

Alex Zinchenko
Added support for cyrillic letters.
It should cover Russian, Ukrainian and Belarusian languages.
@jprichardson

This comment has been minimized.

Show comment
Hide comment
@jprichardson

jprichardson Jun 17, 2013

Owner

This is a small enough change that it doesn't seem to bloat the library too much. But, I'll need to draw the line somewhere. This PR seems like it's OK. In the future, maybe v2, it'll probably make sense to have language specific plugins.

Owner

jprichardson commented Jun 17, 2013

This is a small enough change that it doesn't seem to bloat the library too much. But, I'll need to draw the line somewhere. This PR seems like it's OK. In the future, maybe v2, it'll probably make sense to have language specific plugins.

@yumitsu

This comment has been minimized.

Show comment
Hide comment
@yumitsu

yumitsu Sep 2, 2014

Contributor

This merge request is outdated, but I still can open new one if necessary.

Contributor

yumitsu commented Sep 2, 2014

This merge request is outdated, but I still can open new one if necessary.

@yumitsu yumitsu closed this Sep 2, 2014

@jprichardson

This comment has been minimized.

Show comment
Hide comment
@jprichardson

jprichardson Sep 2, 2014

Owner

Actually, I'm OK with this. Please submit a new one. Don't add anything to the toBoolean though. That method needs to be removed.

Owner

jprichardson commented Sep 2, 2014

Actually, I'm OK with this. Please submit a new one. Don't add anything to the toBoolean though. That method needs to be removed.

@jprichardson jprichardson removed this from the 2.0.0 milestone Sep 2, 2014

@yumitsu

This comment has been minimized.

Show comment
Hide comment
@yumitsu

yumitsu Sep 3, 2014

Contributor

@jprichardson OK, I will think how to make it fit suggestions described in #57.

Contributor

yumitsu commented Sep 3, 2014

@jprichardson OK, I will think how to make it fit suggestions described in #57.

@villelahdenvuo

This comment has been minimized.

Show comment
Hide comment
@villelahdenvuo

villelahdenvuo Dec 8, 2014

For people looking for this I recommend this: https://pid.github.io/speakingurl/

villelahdenvuo commented Dec 8, 2014

For people looking for this I recommend this: https://pid.github.io/speakingurl/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment