Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Cyrillic support. #46

Closed
wants to merge 5 commits into from

3 participants

@yumitsu

It should cover Russian, Ukrainian and Belarusian languages. Related to #43.

Alex Zinchenko Added support for cyrillic letters.
It should cover Russian, Ukrainian and Belarusian languages.
8033309
@jprichardson

This is a small enough change that it doesn't seem to bloat the library too much. But, I'll need to draw the line somewhere. This PR seems like it's OK. In the future, maybe v2, it'll probably make sense to have language specific plugins.

@yumitsu

This merge request is outdated, but I still can open new one if necessary.

@yumitsu yumitsu closed this
@jprichardson
Owner

Actually, I'm OK with this. Please submit a new one. Don't add anything to the toBoolean though. That method needs to be removed.

@jprichardson jprichardson removed this from the 2.0.0 milestone
@yumitsu

@jprichardson OK, I will think how to make it fit suggestions described in #57.

@tuhoojabotti

For people looking for this I recommend this: https://pid.github.io/speakingurl/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 11, 2013
  1. Added support for cyrillic letters.

    Alex Zinchenko authored
    It should cover Russian, Ukrainian and Belarusian languages.
Commits on Jun 22, 2013
  1. Russian lang tools

    Alex Zinchenko authored
Commits on Sep 2, 2014
  1. @yumitsu

    Merge remote-tracking branch 'jprichardson/master' into merge-routine

    yumitsu authored
    Conflicts:
    	lib/string.js
    	test/string.test.js
  2. @yumitsu
  3. @yumitsu

    Fixed README

    yumitsu authored
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 README.md
View
4 README.md
@@ -61,7 +61,7 @@ Checkout this gem to easily use string.js on the asset pipeline: https://github.
```html
<!-- HTML5 -->
-<script src="https://raw.github.com/jprichardson/string.js/master/lib/string.min.js"></script>
+<script src="https://raw.githubusercontent.com/jprichardson/string.js/master/lib/string.min.js"></script>
<!-- Note that in the mime type for Javascript is now officially 'application/javascript'. If you
set the type to application/javascript in IE browsers, your Javscript will fail. Just don't set a
@@ -69,7 +69,7 @@ type via the script tag and set the mime type from your server. Most browsers lo
type anyway -->
<!-- For HTML4/IE -->
-<script type="text/javascript" src="https://raw.github.com/jprichardson/lib/string.js/master/string.min.js"></script>
+<script type="text/javascript" src="https://raw.githubusercontent.com/jprichardson/string.js/master/lib/string.js"></script>
```
A global variable `window.S` or simply `S` is created.
Something went wrong with that request. Please try again.