Feat global partition #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diedpigs
added a commit
to diedpigs/CRI_XCBC
that referenced
this pull request
Dec 3, 2021
The github action result of jprorama#259 shows this bug, which is fixed in a later version. trilom/file-changes-action#93
diedpigs
added a commit
to diedpigs/CRI_XCBC
that referenced
this pull request
Dec 3, 2021
The github action result of jprorama#259 shows this bug, which is fixed in a later version. trilom/file-changes-action#93
|
Tried manually editing those files, works in my cod instance. |
|
e6b1fb8 is optional. |
diedpigs
force-pushed
the
feat-global-partition
branch
from
e6b1fb8
to
27c393b
Compare
This was referenced Aug 19, 2022
diedpigs
force-pushed
the
feat-global-partition
branch
2 times, most recently
from
16bfb26
to
248259f
Compare
diedpigs
force-pushed
the
feat-global-partition
branch
from
248259f
to
7d8e896
Compare
In order to get partition list from cluster setting file, erb function is needed.
diedpigs
force-pushed
the
feat-global-partition
branch
from
7d8e896
to
edcf3b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to solve uabrc#86, this PR makes partitions to be a globally defined variable. This makes it easier to modify the partition list in the future.
This should be merged alone with all ood apps PRs:
Reference: ood-doc